[ENG-6931] Update file shown in MFR when changing versions #2477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjgeiger
approved these changes
Jan 16, 2025
cslzchen
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
I think I verified this locally :)
- Going to version 1 by URL
- Going to version 2 using version drop down, now it makes a new and different request to MFR
- Going to version 2 using URL (full page refresh), it makes the same MFR request as in Step 2.
In addition, I actually went to version 1 when I am on version 1 using the dropdown link (between step 1 and 2) and no MFR request is made, this shows caching works when it should.
futa-ikeda
merged commit a4535b7
into
CenterForOpenScience:feature/preprints-doi-versioning
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
Screenshot(s)
Side Effects
QA Notes